Skip to content

Add gitsubmodule: jsqlflow #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2019
Merged

Add gitsubmodule: jsqlflow #95

merged 3 commits into from
Nov 27, 2019

Conversation

weiguoz
Copy link
Collaborator

@weiguoz weiguoz commented Nov 27, 2019

No description provided.

@weiguoz weiguoz changed the title [WIP] Add submodule: jsqlflow Add gitsubmodule: jsqlflow Nov 27, 2019
shendiaomo
shendiaomo approved these changes Nov 27, 2019
View reviewed changes
Copy link
Collaborator

@shendiaomo shendiaomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz add new .md files to _config.yml if any, or they may ruin the navigator bar on the home page.

@weiguoz
Copy link
Collaborator Author

weiguoz commented Nov 27, 2019

Plz add new .md files to _config.yml if any, or they may ruin the navigator bar on the home page.

OK.
I will add the relative docs when there are enough documents in jsqlflow.

@weiguoz weiguoz merged commit fa1aeb8 into sql-machine-learning:master Nov 27, 2019
@weiguoz weiguoz deleted the add_jsqlflow branch November 27, 2019 08:53
@terrytangyuan
Copy link
Member

terrytangyuan commented Dec 19, 2019 •
edited
Loading

FYI this PR updates all the submodules (instead of just adding jsqflow submodule) which break ElasticDL docs: https://sql-machine-learning.github.io/doc_index/elasticdl/

@wangkuiyi wangkuiyi mentioned this pull request Dec 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shendiaomo shendiaomo shendiaomo approved these changes

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiguoz @terrytangyuan @shendiaomo