Keras models support #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyyang-svail
requested changes
May 22, 2019
tests/base.py
Outdated
| self.setUp() | ||
| train_input_fn(self.features, self.label) | ||
|
|
||
| print('Calling BaseTest:testCommon') |
There was a problem hiding this comment.
Should we also test self.model.fit and self.model.predict here?
|
|
||
| def default_training_epochs(self): | ||
| """Default training epochs. Used in model.fit.""" | ||
| return 2 |
There was a problem hiding this comment.
2 might be too small. Change to 50?
There was a problem hiding this comment.
Tested 2 is enough for iris demo case. Change to 50 maybe take too long to train
wangkuiyi
previously approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed python3.8 test because of this error: https://travis-ci.com/sql-machine-learning/models/jobs/202072631
Related work: sql-machine-learning/sqlflow#424