-
Notifications
You must be signed in to change notification settings - Fork 17
add contribute models doc #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add contribute models doc #14
Conversation
1. Update `sqlflow_models` in the SQLFlow all-in-one Docker container: | ||
|
||
``` bash | ||
> docker exec -it <container-id> pip install -U /models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip install -U
only checks the version, need to uninstall and install it in the container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip install -U /models
works well, but throw an exception for the first execution:
return self._has(path)
File "/miniconda/envs/sqlflow-dev/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 1845, in _has
return zip_path in self.zipinfo or zip_path in self._index()
File "/miniconda/envs/sqlflow-dev/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 1722, in zipinfo
return self._zip_manifests.load(self.loader.archive)
File "/miniconda/envs/sqlflow-dev/lib/python3.6/site-packages/pip/_vendor/pkg_resources/__init__.py", line 1679, in load
mtime = os.stat(path).st_mtime
FileNotFoundError: [Errno 2] No such file or directory: '/miniconda/envs/sqlflow-dev/lib/python3.6/site-packages/sqlflow_models-0.0.1-py3.6.egg'
I'm not sure what is the best practices, will test it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe include a couple more steps mentioned in the comments. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Maybe fix #14 (comment) in the next PR.
No description provided.