Skip to content

Update api.js to improve documentation #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2021
Merged

Update api.js to improve documentation #437

merged 3 commits into from
Jan 30, 2021

Conversation

DavidPratten
Copy link
Contributor

To resolve #435

@lovasoa
Copy link
Member

lovasoa commented Jan 29, 2021

Looks good to me, I'll merge as soon as CI passes (looks like you have a formatting issue).

@DavidPratten
Copy link
Contributor Author

I'm getting the hang of it!

@lovasoa lovasoa merged commit 3685949 into sql-js:master Jan 30, 2021
@DavidPratten
Copy link
Contributor Author

@lovasoa thanks a good experience. My first PR! David

@lovasoa
Copy link
Member

lovasoa commented Jan 31, 2021

Thanks for your contribution ! It is live on sql.js.org : https://sql.js.org/documentation/Statement.html

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of database.prepare() appears to block "DROP TABLE" unless statement.free() is used to clean up.
2 participants
@DavidPratten @lovasoa