Respect the springdoc.cache.disabled setting for recalculating oauth2 redirect url #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uth2 redirect url (as is done with the generated server url in api-docs). When springdoc is reachable under multiple host-names (e.g. through proxies & direct), the authentication-redirect otherwise always contains the host that was generated the first time for that specific instance. A unit-test was also added to ensure this behavior.
|
Thank you for your PR. |
This was referenced Mar 16, 2021
Closed
This was referenced Mar 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request causes the oauth2 redirect url to be recalculated when the springdoc.cache.disabled setting is true, and the url was relative to begin with.
When springdoc is reachable under multiple host-names (e.g. through proxies & direct), the authentication-redirect-url always contains the host that was generated the first time for that specific instance. This PR will recalculate the url every time, when it was originally relative, and the configuration setting to disable caching is set (same behaviour as the generated server url in the api-docs). A unit-test was also added, to ensure this behaviour.
Legal notices below, as per company policy (sorry):
The program was tested solely for our own use cases, which might differ from yours.
Florian Roks <florian.roks@daimler.com>, Daimler TSS GmbH
Imprint
Licensed under APL-2