Property writer-with-order-by-keys not taken into account

[fabienfleureau]

Describe the bug
When springdoc.writer-with-order-by-keys is set to true, in the yaml generated file the keys are not sorted alphabetically
It seems related to this commit:
e77aec1#diff-f7a64fc1c3465d474089ceed1a982db7c484a3c23570ac637948999956614e6dL119
ObjectMapperProvider.java:119
As you can see the ObjectMapper is not configured anymore with MapperFeature.SORT_PROPERTIES_ALPHABETICALLY set to true.

To Reproduce
Steps to reproduce the behavior:

• What version of spring-boot you are using?
  2.7.0
• What modules and versions of springdoc-openapi are you using?
  springdoc-openapi-webmvc-core 1.6.9
  springdoc-openapi-webflux-core 1.6.9
  springdoc-openapi-common 1.6.9
• What is the actual and the expected result using OpenAPI Description (yml or json)?
  yaml

Expected behavior

• A clear and concise description of what you expected to happen.
  I expect the yaml to be generated with keys sorted alphabetically
• What is the expected result using OpenAPI Description (yml or json)?

[fabienfleureau]

This PR should fix the issue:
#1691

[bnasslahsen]

@fabienfleureau,

The sort is working fine. See test below:

• https://github.com/springdoc/springdoc-openapi/blob/master/springdoc-openapi-webmvc-core/src/test/java/test/org/springdoc/api/v30/app138/SpringDocApp138Test.java

If you believe, you are facing any issue, make sure you provide a Minimal, Reproducible Example - with HelloController that reproduces the problem

[mtorba]

Hi @bnasslahsen.
We are facing the same issue now (upgrade from 1.6.8 to 1.6.9 rearranged our output yaml), and I disagree with your assessment, it's not working fine. In fact the very test you linked proves that.
https://github.com/springdoc/springdoc-openapi/blob/master/springdoc-openapi-webmvc-core/src/test/resources/results/3.0.1/app138.json has been edited right before 1.6.9 release (0dc49dd) into non-alphabetic parameter order:
"parameters":[{"name":"hello","in":"query","required":true,"schema":{"type":"string"}}]
from
"parameters":[{"in":"query","name":"hello","required":true,"schema":{"type":"string"}}]
I would argue that this test currently validates incorrect behaviour.

[mariusz-zawadzki]

I've created a new PR with expectations fixed:
#1713

app138.json is a copy from from tag v1.6.8

[bnasslahsen]

Thank you @mariusz-zawadzki for your contirbution to the project.
You change, is now merged.