Skip to content

Create the CSRF token on the bounded elactic scheduler #8534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020

Conversation

cbornet
Copy link
Contributor

@cbornet cbornet commented May 15, 2020

The CSRF token is created with a call to UUID.randomUUID which is blocking.
This change ensures this blocking call is done on the bounded elastic scheduler which supports blocking calls.

Fixes gh-8128

The CSRF token is created with a call to UUID.randomUUID which is blocking.
This change ensures this blocking call is done on the bounded elastic scheduler which supports blocking calls.

Fixes spring-projectsgh-8128
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 15, 2020
@rwinch rwinch removed the status: waiting-for-triage An issue we've not yet triaged label May 18, 2020
@rwinch rwinch self-assigned this May 18, 2020
@rwinch rwinch added type: bug A general bug in: web An issue in web modules (web, webmvc) labels May 18, 2020
@rwinch rwinch added this to the 5.4.0-M2 milestone May 18, 2020
@rwinch rwinch merged commit bfb401e into spring-projects:master May 18, 2020
@rwinch
Copy link
Member

rwinch commented May 18, 2020

Thanks for the report! A fix is now merged into master :) I've also backported as far back as 5.0.x

@cbornet cbornet deleted the gh-8128 branch May 18, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocking in WebSessionServerCsrfTokenRepository
3 participants