Resolve JavaType only once for whitelisted class #7755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
eleftherias
suggested changes
Dec 31, 2019
There was a problem hiding this comment.
Thanks for the PR @MatthiasStock! I have left one small comment inline.
core/src/main/java/org/springframework/security/jackson2/SecurityJackson2Modules.java
Show resolved
Hide resolved
eleftherias
added
in: core
m7stock
force-pushed
the
whitelist-reuse-javatype
branch
from
6c2fe94 to
98689c2
Compare
|
Thanks for the PR @MatthiasStock! This is now merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Jackson 2
JavaTypeis unnecessarily resolved twice when a class is whitelisted. This should be the most likely case. The delegate doing this may be aClassNameIdResolverwhose operations seem rather complex, so it would be a good idea to avoid a call.Actual Behavior
JavaTypes are resolved twice for a whitelisted class.
Expected Behavior
JavaTypes are resolved only once for a whitelisted class.