Reactive Implementation of AuthorizedClientServiceOAuth2AuthorizedClientManager (take 2) #7702
Conversation
…entManager ReactiveOAuth2AuthorizedClientServiceReactiveOAuth2AuthorizedClientManager is reactive version of AuthorizedClientServiceOAuth2AuthorizedClientManager Fixes: spring-projectsgh-7569
spring-projects-issues
added
the
status: waiting-for-triage
|
Hi @philsttr I checked with my use case and all is fine. Thanks for the implementation |
jgrandja
added
in: oauth2
We typically don't backport when new artifacts are added. However, since the feature is isolated in a new class, I'm not concerned with any compatibility issues. I'll backport this to 5.2.x for you. |
There was a problem hiding this comment.
Thanks for the updates @philsttr. I left a couple of minor comments.
Let's leave @ankurpathak commit and change your commit message to "Polish #7589"
...ork/security/oauth2/client/AuthorizedClientServiceReactiveOAuth2AuthorizedClientManager.java
Outdated
Show resolved
Hide resolved
...ork/security/oauth2/client/AuthorizedClientServiceReactiveOAuth2AuthorizedClientManager.java
Outdated
Show resolved
Hide resolved
...ecurity/oauth2/client/AuthorizedClientServiceReactiveOAuth2AuthorizedClientManagerTests.java
Show resolved
Hide resolved
Rename OAuth2AuthorizedClientServiceReactiveOAuth2AuthorizedClientManager to AuthorizedClientServiceReactiveOAuth2AuthorizedClientManager. Handle empty mono returned from contextAttributesMapper. Handle empty map returned from contextAttributesMapper. Fix DefaultContextAttributesMapper so that it doesn't access ServerWebExchange. Fix unit tests so that they pass. Use StepVerifier in unit tests, rather than .subscribe(). Fixes spring-projectsgh-7569
|
@jgrandja I've addressed all of your comments, and force pushed an update to the commit message. |
|
Thanks @philsttr ! This is now in master and 5.2.x. |
This is a continuation of PR #7589, and addresses all the code/test fixes mentioned in its review comments.
PR #7589 should be closed in favor of this PR. Thank you @ankurpathak for the initial implementation! I left @ankurpathak 's commit as a separate commit so that he gets credit for his initial work. I can squash this if needed, however. Let me know.
I'd really appreciate it if this was also backported to 5.2.x. It should be simple to backport, since this functionality is isolated in a new class.
Fixes #7569