Fix InitializeAuthenticationProviderBeanManagerConfigurer Javadoc #7666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
eleftherias
suggested changes
Nov 27, 2019
There was a problem hiding this comment.
Thanks for the PR @xak2000!
One small request, can you please update the date range in the license header to be 2019 in the InitializeAuthenticationProviderBeanManagerConfigurer class?
eleftherias
added
in: docs
|
Thanks for the PR @xak2000! This is now merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the javadoc of class
InitializeAuthenticationProviderBeanManagerConfigureris copy-pasted fromInitializeUserDetailsBeanManagerConfigurer. This PR just fixes the Javadoc and removes an unnecessary import.This also fixes copy-pasted class and variable names in
InitializeAuthenticationProviderBeanManagerConfigurerclass and also fixes variable name inInitializeUserDetailsBeanManagerConfigurer:userDetailsBeanNames->beanNamesas the names returned for bean type that depends on method parameter and they are not alwaysUserDetailsServicetype (the methodgetBeanOrNullis called several times with different 'type' argument actually).