Check BCrypt hashes of byte array passwords #7662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
eleftherias
suggested changes
Nov 29, 2019
There was a problem hiding this comment.
Thank you for the PR @rafahop!
I've left a couple of comments inline.
crypto/src/test/java/org/springframework/security/crypto/bcrypt/BCryptTests.java
Outdated
Show resolved
Hide resolved
crypto/src/test/java/org/springframework/security/crypto/bcrypt/BCryptTests.java
Show resolved
Hide resolved
eleftherias
added
in: crypto
eleftherias
suggested changes
Dec 13, 2019
There was a problem hiding this comment.
A couple of small things left @rafahop and then we should be good to merge.
crypto/src/main/java/org/springframework/security/crypto/bcrypt/BCrypt.java
Show resolved
Hide resolved
crypto/src/main/java/org/springframework/security/crypto/bcrypt/BCrypt.java
Outdated
Show resolved
Hide resolved
eleftherias
suggested changes
Dec 13, 2019
There was a problem hiding this comment.
@rafahop All looks good, except there are some conflicts that are preventing me from merging.
Could you please squash your commits into one and rebase on the latest master branch to fix any conflicts?
|
All done @eleftherias ! 👍 |
|
Thanks for the PR @rafahop! This is now merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCrypt: add missing overloaded version of
checkpwaccepting a byte array.Fixes gh-7661