-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Deserialize details field in UsernamePasswordAuthenticationToken #7660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before this commit, the details field was set to a JsonNode, but now it is deserialized correctly. Fixes gh-7482
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for the scenario that this commit fixes.
The test should go in the class UsernamePasswordAuthenticationTokenMixinTests
.
Thanks for the PR @buzzerrookie! This is now merged into master. |
Hi @eleftherias , Could you back-port this to 5.2 branch ? |
@reda-alaoui You can add a mixin which uses the right UsernamePasswordAuthenticationTokenDeserializer to replace the default.
In the code above, UsernamePasswordAuthenticationTokenMixin is your own mixin using the right UsernamePasswordAuthenticationTokenDeserializer. |
Thanks for providing a workaround @buzzerrookie. |
Before this commit, the details field was set to a JsonNode, but now it is deserialized correctly.
Fixes gh-7482