Skip to content

Support overriding WebClient/RestOperations in (Reactive)OidcIdTokenDecoderFactory #14357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2024
Merged

Support overriding WebClient/RestOperations in (Reactive)OidcIdTokenDecoderFactory #14357

merged 2 commits into from
Jan 19, 2024

Conversation

krezovic
Copy link
Contributor

Discussed in the mentioned issue and implemented as suggested by @jzheaux.

  • Adds support for overriding WebClient passed to NimbusReactiveJwtDecoder in ReactiveOidcIdTokenDecoderFactory
  • Adds support for overriding RestOperations passed to NimbusJwtDecoder in OidcIdTokenDecoderFactory

Closes: gh-14178

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 20, 2023
@sjohnr sjohnr added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Dec 28, 2023
@jzheaux jzheaux added this to the 6.3.0-M2 milestone Jan 19, 2024
@jzheaux jzheaux added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 19, 2024
@jzheaux jzheaux merged commit 9c352c4 into spring-projects:main Jan 19, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Jan 19, 2024

Thanks, @krezovic! This is now merged into main. I also added a polish to update the copyright years to 2024.

This was referenced Feb 1, 2024
Closed
Merged
@JohnNiang
Copy link
Contributor

JohnNiang commented Oct 29, 2024 •
edited
Loading

Hi @jzheaux , did we miss the commit 566634e which supports ReactiveOidcIdTokenDecoderFactory and is supposed to be merged?

See

for more.

@JohnNiang JohnNiang mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
6.3.0-M2
Development

Successfully merging this pull request may close these issues.

Cannot override WebClient for NimbusReactiveJwtDecoder in ReactiveOidcIdTokenDecoderFactory
5 participants
@krezovic @jzheaux @JohnNiang @sjohnr @spring-projects-issues