Skip to content

Simplify Request Authorization Path Extraction #13574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2023
Merged

Simplify Request Authorization Path Extraction #13574

merged 1 commit into from
Dec 20, 2023

Conversation

kth496
Copy link
Contributor

@kth496 kth496 commented Jul 22, 2023

It is a great pleasure to write first PR on Spring Security.
This PR closes gh-13256

  • Implement hasVariable and equalTo to simplify request authorization path extraction.
  • I wonder if this is the best way.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 22, 2023
jzheaux
jzheaux requested changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kth496 for the PR! And thank you for your patience as I got around to it. I've left some feedback inline.

@jzheaux jzheaux self-assigned this Dec 16, 2023
@jzheaux jzheaux added in: config An issue in spring-security-config type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 16, 2023
@kth496
Copy link
Contributor Author

kth496 commented Dec 18, 2023

@jzheaux Thank you for your detailed code review. I've implemented your review and beefed up the test cases. I've also rebased on to the main branch.

@jzheaux jzheaux added this to the 6.3.0-M1 milestone Dec 20, 2023
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Dec 20, 2023
@jzheaux jzheaux merged commit ec02c22 into spring-projects:main Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

@marcusdacoregio marcusdacoregio marcusdacoregio approved these changes

Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
6.3.0-M1
Development

Successfully merging this pull request may close these issues.

Simplify Request Authorization Path Extraction
4 participants
@kth496 @jzheaux @marcusdacoregio @spring-projects-issues