Skip to content

BasicLookupStrategy for ACL defines the ObjectIdentity as not interchangable #10079

Closed
@Ditscheridou

Description

@Ditscheridou

Describe the bug
The BasicLookupStrategy in Spring-ACL is fore most cases fine and good designed for interchangeable implementations. But the BasicLookupStrategy defines the ObjectIdentity to use hard in the code, instead of making it interchangeable due to some setters and programming against the Interface ObjectIdentity.

For most cases, this standard Implementation is fine, so creating an own implementation of this class is overkill. It would be nice if we could make this class a little bit more open for changes!

To Reproduce
Look at BasicookupStrategy Line 572. You dont have an influence here which ObjectIdentity we can use. Its hard coded to ObjectIdentityImpl.

Expected behavior
Program against ObjectIdentity interface and make it interchangeable due a constructor parameter or setMethod.

Sample

A link to a GitHub repository with a minimal, reproducible sample.

Reports that include a sample will take priority over reports that do not.
At times, we may require a sample, so it is good to try and include a sample up front.

Metadata

Metadata

Assignees

Labels

in: aclAn issue in spring-security-acltype: enhancementA general enhancement

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions