GH-4002: Deprecate ConsumerStopAction in MQTT
#4006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#4002 Turns out the `ConsumerStopAction` was introduced in a point version to mitigate an unsubscription bug and let to preserve a previous behaviour. * Deprecate `ConsumerStopAction` in favor of just `cleanSession` flag in the `MqttConnectOptions` **Cherry-pick to `5.5.x`**
garyrussell
approved these changes
Feb 6, 2023
garyrussell
pushed a commit
that referenced
this pull request
Feb 6, 2023
Fixes #4002 Turns out the `ConsumerStopAction` was introduced in a point version to mitigate an unsubscription bug and let to preserve a previous behaviour. * Deprecate `ConsumerStopAction` in favor of just `cleanSession` flag in the `MqttConnectOptions` **Cherry-pick to `5.5.x`**
|
...and cherry-picked as b088091 after resolving conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4002
Turns out the
ConsumerStopActionwas introduced in a point version to mitigate an unsubscription bug and let to preserve a previous behaviour.ConsumerStopActionin favor of justcleanSessionflag in theMqttConnectOptionsCherry-pick to
5.5.x