Skip to content

GH-3243: sync computeIfAbsent in StoredProcExec #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2020
Merged

GH-3243: sync computeIfAbsent in StoredProcExec #3244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...tegration-jdbc/src/main/java/org/springframework/integration/jdbc/StoredProcExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ public class StoredProcExecutor implements BeanFactoryAware, InitializingBean {

private final DataSource dataSource;

private final Object jdbcCallOperationsMapMonitor = new Object();

private Map<String, RowMapper<?>> returningResultSetRowMappers = new HashMap<>(0);

private EvaluationContext evaluationContext;
Expand Down Expand Up @@ -296,7 +298,14 @@ private Map<String, Object> executeStoredProcedureInternal(Object input, String
}

private SimpleJdbcCallOperations obtainSimpleJdbcCall(String storedProcedureName) {
return this.jdbcCallOperationsMap.computeIfAbsent(storedProcedureName, this::createSimpleJdbcCall);
SimpleJdbcCallOperations operations = this.jdbcCallOperationsMap.get(storedProcedureName);
if (operations == null) {
synchronized (this.jdbcCallOperationsMapMonitor) {
operations =
this.jdbcCallOperationsMap.computeIfAbsent(storedProcedureName, this::createSimpleJdbcCall);
}
}
return operations;
}

//~~~~~Setters for Properties~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Expand Down