Skip to content

INT-3529 Add 'expire-groups-upon-timeout' to Reseq #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

INT-3529 Add 'expire-groups-upon-timeout' to Reseq #1296

wants to merge 2 commits into from

Conversation

garyrussell
Copy link
Contributor

JIRA: https://jira.spring.io/browse/INT-3529

Late arriving messages will now be immediately discarded by
default.

@artembilan
Copy link
Member

Polishing for your confirmation: artembilan@7d02ed7
BTW, my branch is rebased to the master with fixed conflicts

@garyrussell
Copy link
Contributor Author

The polish is incorrect - consider a resequencer with releasePartialSequences=true (which has a SequenceSizeReleaseStrategy with releasePartialSequences=true). We don't want to complete the group when only a partial release was done.

That's why I had to complete the group only when timing out.

@artembilan
Copy link
Member

Ah! Yes. Sorry. Anyway how about to complete group before afterRelease? Because the last one may remove group. So, our complete amy form a new emty group.
Or is it intentional ?

@garyrussell
Copy link
Contributor Author

Good point - I originally was going to add a boolean (expiring) to afterRelease() but decided this was ok. I think I'll go back to that approach.

@garyrussell
INT-3529 Add 'expire-groups-upon-timeout' to Reseq
d0d215a 
JIRA: https://jira.spring.io/browse/INT-3529

Late arriving messages will now be immediately discarded by
default.
@garyrussell
INT-3529 Polishing
a0e3434 
Move group completion to the Resequencer's `afterRelease()` when
the group is timed out.
@garyrussell
Copy link
Contributor Author

Pushed

@artembilan
Copy link
Member

LGTM. Merging...

@artembilan
Copy link
Member

Merged after rebase and squesh

@artembilan artembilan closed this Oct 16, 2014
@garyrussell garyrussell deleted the INT-3529 branch October 24, 2014 19:19
@spring-operator spring-operator mentioned this pull request Oct 27, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyrussell @artembilan