Skip to content

bypass arguments parsing when target type is a map #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,19 @@ public Object resolveArgument(MethodParameter parameter, DataFetchingEnvironment
if (CollectionFactory.isApproximableCollectionType(rawValue.getClass())) {
Assert.isAssignable(Collection.class, parameterType.getType(),
"Argument '" + name + "' is a Collection while the @Argument method parameter is " + parameterType.getType());

if (parameterType.getElementTypeDescriptor().getType() == Map.class) {
return rawValue;
}

Class<?> elementType = parameterType.getElementTypeDescriptor().getType();
return this.instantiator.instantiateCollection(elementType, (Collection<Object>) rawValue);
}

if (parameterType.isMap()) {
return rawValue;
}

MethodParameter nestedParameter = parameter.nestedIfOptional();
Object value = convert(rawValue, nestedParameter.getNestedParameterType());
return returnValue(value, parameterType.getType());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@


import java.lang.reflect.Method;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

Expand Down Expand Up @@ -98,6 +99,32 @@ void shouldResolveListOfJavaBeansArgument() throws Exception {
.extracting("name").containsExactly("first", "second");
}

@Test
void shouldPassArgumentAsMap() throws Exception {
Method updateBook = ClassUtils.getMethod(BookController.class, "updateBook", Long.class, Map.class);
String payload = "{\"id\": 43, \"input\": { \"name\": \"new name\", \"description\": null, \"authorId\": 42} }";
DataFetchingEnvironment environment = initEnvironment(payload);
MethodParameter methodParameter = getMethodParameter(updateBook, 1);
Object result = resolver.resolveArgument(methodParameter, environment);
assertThat(result).isNotNull().isInstanceOf(Map.class);
assertThat(result)
.hasFieldOrPropertyWithValue("name", "new name")
.hasFieldOrPropertyWithValue("description", null)
.hasFieldOrPropertyWithValue("authorId", 42);
}

@Test
void shouldPassArgumentAsList() throws Exception {
Method updateBook = ClassUtils.getMethod(BookController.class, "updateBooks", List.class);
String payload = "{\"input\": [{ \"id\": 1, \"name\": \"first\" }, { \"id\": 2, \"name\": \"second\" }] }";
DataFetchingEnvironment environment = initEnvironment(payload);
MethodParameter methodParameter = getMethodParameter(updateBook, 0);
Object result = resolver.resolveArgument(methodParameter, environment);
assertThat(result).isNotNull().isInstanceOf(List.class);
assertThat(result).asList().allMatch(item -> item instanceof Map)
.extracting("name").containsExactly("first", "second");
}

private MethodParameter getMethodParameter(Method method, int index) {
MethodParameter methodParameter = new MethodParameter(method, index);
methodParameter.initParameterNameDiscovery(new DefaultParameterNameDiscoverer());
Expand Down Expand Up @@ -132,6 +159,16 @@ public List<Book> addBooks(@Argument List<Book> books) {
return null;
}

@MutationMapping
public List<Book> updateBook(@Argument Long id, @Argument Map<String, ?> input) {
return null;
}

@MutationMapping
public List<Book> updateBooks(@Argument List<Map<String, ?>> input) {
return null;
}

}

static class BookInput {
Expand Down