Add merged annotation support to @CrossOrigin #877
Conversation
Issue: SPR-13468 I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Documented | ||
| @CrossOrigin | ||
| private @interface CrossOriginMetaAnnotation { |
There was a problem hiding this comment.
This is a composed annotation, not a meta-annotation.
@CrossOrigin is a meta-annotation in this context.
There was a problem hiding this comment.
@crossorigin is a meta-annotation in this context.
This is the meaning of the annotation name. Is CrossOriginSetAsMetaAnnotation better ?
There was a problem hiding this comment.
I'm being picky for a reason.... people often confuse "meta-annotation" and "composed annotation" and that makes it difficult to discuss the topic. So I'm a proponent for a ubiquitous language in this context. See the following for details:
With that in mind, something like @ComposedCrossOrigin or @MyCrossOrigin (or something directly related to the use case) would provide more clarity for the intent.
There was a problem hiding this comment.
Thanks for the link!
Do you expect a new commit or as you take the issue on JIRA, are you correcting the issue on your own?
There was a problem hiding this comment.
Since I'm handling the JIRA issue now, I'll fix it on my own when I merge the commit.
cheers!
* SPR-13468: Support @crossorigin as a merged composed annotation
|
Merged into |
Issue: SPR-13468
I have signed and agree to the terms of the SpringSource Individual
Contributor License Agreement.