NPE in AutowiredAnnotationBeanPostProcessor #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutowiredAnnotationBeanPostProcessor.determineRequiredStatus never checks the return value of ReflectionUtils.findMethod. This method returns null for @Inject @value @resource in which case a NullPointerException is thrown in ReflectionUtils.invokeMethod and caught in AutowiredAnnotationBeanPostProcessor.determineRequiredStatus. - check return value of ReflectionUtils.findMethod - default to required if no required method is found - existing test cases cover both cases Issue: SPR-9316
|
Hi Phillipe, Could you indicate whether you've signed the CLA, per the contributor guidelines? Thanks. |
|
Yes I did. Do you need my confirmation number? |
|
No, just need to know that it's been done. Please add a note to your other open pull requests to this effect as well, thanks! |
cbeams
added a commit
that referenced
this pull request
May 16, 2012
* SPR-9316: Avoid NPE in AutowiredAnnotationBeanPostProcessor
|
Thanks Philippe! This is merged. |
rwinch
pushed a commit
to rwinch/spring-framework
that referenced
this pull request
Jun 20, 2016
rwinch
pushed a commit
to rwinch/spring-framework
that referenced
this pull request
Jun 20, 2016
rwinch
pushed a commit
to rwinch/spring-framework
that referenced
this pull request
Jul 13, 2016
rwinch
pushed a commit
to rwinch/spring-framework
that referenced
this pull request
Jul 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutowiredAnnotationBeanPostProcessor.determineRequiredStatus never
checks the return value of ReflectionUtils.findMethod. This method
returns null for @Inject @value @resource in which case a
NullPointerException is thrown in ReflectionUtils.invokeMethod and
caught in AutowiredAnnotationBeanPostProcessor.determineRequiredStatus.
Issue: SPR-9316