Fix JibxMarshallerTests failing on Windows #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change JibxMarshallerTests would fail on Windows with error message explaining that JiBX compiler generated classes are not found on classpath for binding with name 'binding'. Tests would execute well on Linux. Actual root cause of this bug is found to be in JiBX 1.1.5 release that is used to build Spring. Binding name can be explicitly specified in JiBX binding file. If omitted, when generating classes JiBX compiler as fall-back mechanism tries to derive binding name from binding file name. That logic had bug which gets manifested when configured binding file path has mixed Windows and Linux style file separators, as in case when mentioned JibxMarshallerTests are executed on Windows platform. This change introduces one of the two possible solutions - binding name is specified explicitly in binding.xml file so JiBX doesn't have to use the fall-back mechanism. Issue: SPR-8360
Before this change JibxMarshallerTests would fail on Windows with error message explaining that JiBX compiler generated classes are not found on classpath for binding with name 'binding'. Tests would execute well on Linux. Actual root cause of this bug is found to be in JiBX 1.1.5 release that is used to build Spring. Binding name can be explicitly specified in JiBX binding file. If omitted, when generating classes JiBX compiler as fall-back mechanism tries to derive binding name from binding file name. That logic had bug which gets manifested when configured binding file path has mixed Windows and Linux style file separators, as in case when mentioned JibxMarshallerTests are executed on Windows platform. This change introduces one of the two possible solutions - since this bug was fixed in JiBX 1.2 (see JIBX-441 for more details), dependency to JiBX is upgraded from 1.1.5 to the latest 1.2.3 release. For build to pass with this change, public access to 1.2.3 version of JiBX has to be granted on SpringSource libs-release repository (http://repo.springsource.org/libs-release). Issue: SPR-8360
|
I prefer to do the JiBX update, i.e. commit 86eba90 |
cbeams
added a commit
that referenced
this pull request
May 17, 2012
* SPR-8360: Fix JibxMarshallerTests failing on Windows
|
The problem still exist in 3.2.x branch and I tried your solution, but it didn't work. org.jibx.runtime.JiBXException: Unable to access binding information for class org.springframework.oxm.jibx.Flights BTW, OS is WIN7 64bit with JDK8 |
rwinch
pushed a commit
to rwinch/spring-framework
that referenced
this pull request
Jul 13, 2016
This commit changes the AbstractResponseBodySubscriber into a AbstractResponseBodyProcessor<DataBuffer, Void>, so that the processor can be used as a return value for writeWith. Additional, this commit no longer closes the response after an eror occurred. This fixes spring-projects#59.
This was referenced Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change JibxMarshallerTests would fail on Windows with error
message explaining that JiBX compiler generated classes are not found
on classpath for binding with name 'binding'. Tests would execute well
on Linux.
Actual root cause of this bug is found to be in JiBX 1.1.5 release that
is used to build Spring. Binding name can be explicitly specified in
JiBX binding file. If omitted, when generating classes JiBX compiler as
fall-back mechanism tries to derive binding name from binding file
name. That logic had bug which gets manifested when configured binding
file path has mixed Windows and Linux style file separators, as in case
when mentioned JibxMarshallerTests are executed on Windows platform.
This pull request contains two commits for two different solutions for this
issue. See respective commit comments for more details.
Issue: SPR-8360
I have signed and agree to the terms in the SpringSource Individual Contributor License Agreement.