fixed some warnings in Eclipse mostly be removing @SuppressWarnings that... #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Phillipe, These changes should be fine; as mentioned in #37, please just touch up the commit according to the contributor guidelines Cheers! |
ghost
assigned 
|
I did sign the CLA. |
|
Hi Philippe, Still happy to commit this; could you touch up the commit comment formatting per the guidelines? Thanks. |
The Spring code base causes several warnings in Eclipse. This can be problematic because it's hard to tell which of these indicate a potential problem in the code and which are just noise. This patch fixes several Eclipse warnings that do not point to code problems. Two kinds of warnings are fixed. First in a lot of cases @SuppressWarnings("unchecked") is used although there are no unchecked casts happening. This seems to be a leftover from when the code base was on Java 1.4, now that the code base was moved to Java 1.5 these are no longer necessary. Secondly there some places where the raw types of List and Class are used where there wildcard types (List<?> and Class<?>) would work just as well without causing any raw type warnings. This patch contains the following changes: - remove @SuppressWarnings where no longer needed - use wildcard types instead of raw types where possible - update the Apache license header of modified files
|
Done, I also did a rebase against the current master. |
cbeams
added a commit
that referenced
this pull request
May 17, 2012
* warnings: Fix compiler warnings
|
Nice! Thanks Philippe, this is committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I'm new to git and I thought it's best to start with something small. This fixes several warnings in Eclipse. It's mostly places that have a @SuppressWarnings annotation but no longer need it, probably because the code was generified in Spring 3.
Cheers
Philippe