Skip to content

Polish ServletWebRequest and DefaultServerWebExchange #29460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Polish ServletWebRequest and DefaultServerWebExchange #29460

wants to merge 4 commits into from

Conversation

divcon
Copy link
Contributor

@divcon divcon commented Nov 10, 2022 •
edited
Loading

  1. Remove unused return value
  2. Add Nullable annotaions
  3. Simplify if statement

@divcon
remove return statements of ServletWebRequest.validateIfUnmodifiedSin…
cadc58c 
…ce and DefaultServerWebExchange.validateIfUnmodifiedSince

The return values of ServletWebRequest.validateIfUnmodifiedSince and DefaultServerWebExchange.validateIfUnmodifiedSince don't seem to be in used.
So I think that it is better to remove return statement.
@divcon
Add @nullable annotation.
8c50fc3
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 10, 2022
sbrannen
sbrannen requested changes Nov 21, 2022
View reviewed changes
@sbrannen sbrannen marked this pull request as draft November 21, 2022 16:11
@sbrannen sbrannen added status: waiting-for-feedback We need additional information before we can continue in: web Issues in web modules (web, webmvc, webflux, websocket) labels Nov 21, 2022
@divcon
Copy link
Contributor Author

divcon commented Nov 22, 2022 •
edited
Loading

@sbrannen
Thank you for your review.
I reflected your review.

@divcon divcon marked this pull request as ready for review November 22, 2022 06:06
@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Nov 22, 2022
@divcon divcon requested a review from sbrannen November 22, 2022 09:00
@sbrannen sbrannen changed the title Small polish Polish ServletWebRequest and DefaultServerWebExchange Nov 22, 2022
@sbrannen sbrannen added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on status: feedback-provided Feedback has been provided labels Nov 22, 2022
@sbrannen sbrannen self-assigned this Nov 22, 2022
@sbrannen sbrannen added this to the 6.0.1 milestone Nov 22, 2022
@sbrannen sbrannen closed this in c12d93c Nov 22, 2022
sbrannen added a commit that referenced this pull request Nov 22, 2022
@sbrannen
Polish contribution
a832c98 
See gh-29460
@sbrannen
Copy link
Member

This has been merged into main in c12d93c and revised in a832c98.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrannen sbrannen sbrannen approved these changes

Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Projects
None yet
Milestone
6.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@divcon @sbrannen @spring-projects-issues