Skip to content

Polish #26675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Polish #26675

merged 1 commit into from
Mar 15, 2021

Conversation

Rebwon
Copy link
Contributor

@Rebwon Rebwon commented Mar 14, 2021

This PR fixes polishes trivial stuff.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 14, 2021
@sbrannen sbrannen added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 15, 2021
@sbrannen sbrannen self-assigned this Mar 15, 2021
@sbrannen sbrannen added this to the 5.3.5 milestone Mar 15, 2021
@sbrannen sbrannen merged commit 2728a9b into spring-projects:master Mar 15, 2021
@sbrannen
Copy link
Member

This has been merged into master.

Thanks

sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Mar 15, 2021
@sbrannen
Copy link
Member

For future reference, when polishing test assertions like that, please favor idiomatic AssertJ APIs as I did in 70f0895.

@Rebwon
Copy link
Contributor Author

Rebwon commented Mar 15, 2021

@sbrannen Thank you for advice.

@Rebwon Rebwon deleted the polish-20210314 branch April 14, 2021 01:39
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants