Skip to content

SPR-16956 - Propagate read-only status as FlushMode.MANUAL to Hibernate Session #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vladmihalcea
Copy link

@pivotal-issuemaster
Copy link

@vladmihalcea Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@vladmihalcea Thank you for signing the Contributor License Agreement!

@jhoeller
Copy link
Contributor

jhoeller commented Jul 5, 2018

As per our JIRA discussion, this has been rolled into master in a slightly extended fashion, only applying setDefaultReadOnly(true) to transaction-local resources... which means no side effects for later access, and no cleanup neessary. Thanks for the PR, in any case!

@jwgmeligmeyling
Copy link

@jhoeller was similar behaviour ever implemented for Hibernate 6?

@vladmihalcea
Copy link
Author

@jwgmeligmeyling Yes, the optimizations work just fine with Hibernate 6 because they are applied by the HibernateJpaDialect.

Check out this line in the HibernateJpaDialect for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants