SPR-9275 Cache Abstraction Exception Handling #138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
native cache implementation. FailSafeCache is intended to wrap existing cache implementations and gracefully handle any Exceptions thrown by the native cache. The AbstractCacheManager is responsible for wrapping the native cache(s) IF the gracefullyHandleExceptions property is *true*. Otherwise, the behavior of the AbstractCacheManager remains unchanged. Issue: SPR-9275
|
Wow, I wasn't even aware of that PR. You're probably aware that SPR-9275 has been implemented in 4.1 in a slightly different approach. Thanks for the PR anyway! |
rstoyanchev
added a commit
that referenced
this pull request
Jul 18, 2017
Since there is no reason for an exchange to ever complete without a ClientResponse I've added a switchIfEmpty check at the WebClient level. Also, temporarily a second check closer to the problem in the ReactorClientHttpConnector suggesting a workaround and providing a reference to the Reactor Netty issue #138. Issue: SPR-15784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced FailSafeCache.
FailSafeCache is intended to wrap existing cache implementations and
gracefully handle any Exceptions thrown by the native cache. The
AbstractCacheManager is responsible for wrapping the native cache(s) IF
the gracefullyHandleExceptions property is true. Otherwise, the
behavior of the AbstractCacheManager remains unchanged.
Issue: SPR-9275
I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.