SPR-9692: Change to match converter to interface before Enum #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GenericConversionService changed to not match converter to Enum.class before trying to match converter to an interface. Prior to this commit a converter would be matched to the superclass of an enum (which will always be Enum.class) ignoring converters matching the interface. Enum.class will now be ignored when retrieving superclasses and only after trying to match converters to interfaces will it try to match converters to Enum (just before trying to match to Object). This is the behaviour encountered prior to 3.1.0. Issue: SPR-9692
ghost
assigned 
|
@cbeams : Correct. Pull 132 fixes this issue (albeit in a slightly different way) |
rwinch
pushed a commit
to rwinch/spring-framework
that referenced
this pull request
Jul 13, 2016
…-state AbstractRequestBodyPublisher.onDataAvailable improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GenericConversionService changed to not match converter to Enum.class
before trying to match converter to an interface.
Prior to this commit a converter would be matched to the superclass of
an enum (which will always be Enum.class) ignoring converters matching
the interface.
Enum.class will now be ignored when retrieving superclasses and only
after trying to match converters to interfaces will it try to match
converters to Enum (just before trying to match to Object).
This is the behaviour encountered prior to 3.1.0.
Issue: SPR-9692
I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.