SPR-12031 Support @ContextConfiguration at method level #1255
Conversation
fdesu
force-pushed
the
feature/SPR-12031-rebase
branch
8 times, most recently
from
a8bb1f2 to
4f7aed0
Compare
| import org.springframework.stereotype.Component; | ||
| import org.springframework.util.ClassUtils; | ||
| import org.springframework.util.ReflectionUtils; | ||
|
|
There was a problem hiding this comment.
In general, contributors are required to adhere to the Spring Framework Code Style. So please familiarize yourself with that and rework your PR.
For example, you need to undo all changes to import ordering and static imports throughout all changed classes.
| assertTrue(isAnnotationDeclaredLocally(Order.class, NonInheritedAnnotationClass.class)); | ||
| assertFalse(isAnnotationDeclaredLocally(Order.class, SubNonInheritedAnnotationClass.class)); | ||
| } | ||
| // non-inherited class-level annotation; note: @Order is not inherited |
There was a problem hiding this comment.
It appears that you formatted code that you have not authored or modified, which is not permissible according to Spring's coding guidelines.
Also, it appears you may be using the wrong indentation settings.
| @@ -105,7 +110,7 @@ | |||
| } | |||
|
|
|||
| // Declared locally? | |||
| if (AnnotationUtils.isAnnotationDeclaredLocally(annotationType, clazz)) { | |||
| if (isAnnotationDeclaredLocally(annotationType, clazz)) { | |||
There was a problem hiding this comment.
Production code is not allowed to use static imports.
|
@sbrannen |
It's definitely forbidden in production code. In test code, I think there are few places where that style is used. But I don't want that in the Thanks |
fdesu
force-pushed
the
feature/SPR-12031-rebase
branch
from
4f7aed0 to
e3d8c85
Compare
Prior Spring TestContext Framework had not supported @ContextConfiguration annotation on the method-level. This commit enables @ContextConfiguration and @ContextHierarchy to be the method-level annotations. Now TCF will emit fully configured throw-away TestContext for the particular test method. Issue: SPR-12031
fdesu
force-pushed
the
feature/SPR-12031-rebase
branch
from
e3d8c85 to
ae37c63
Compare
|
@sbrannen |
Prior Spring TestContext Framework had not supported
@ContextConfiguration annotation on the method-level.
This commit enables @ContextConfiguration and
@ContextHierarchy to be the method-level annotations.
Now TCF will emit fully configured throw-away
TestContext for the particular test method.
Issue: SPR-12031