Skip to content

Fix broken javadoc #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fix broken javadoc #1097

wants to merge 6 commits into from

Conversation

nkjackzhang
Copy link
Contributor

The javadocs are broken where lines start with "@{".

I have signed and agree to the terms of the Spring Individual Contributor
License Agreement.

The javadoc is broken where lines start with with "@{".

I have signed and agree to the terms of the Spring Individual Contributor
License Agreement.
I have signed and agree to the terms of the Spring Individual Contributor
License Agreement.
@snicoll
Copy link
Member

snicoll commented Jul 1, 2016

@nkjackzhang indeed and I was about to scan the documentation to fix the remaining ones. A couple of remarks:

  • Please submit one commit instead of those individual commits: you can rebase and squash to a single commit and push force on your branch and it will update this PR
  • Please take the line wrapping into account, several changes are breaking our code format style.

The one big exception to the above line wrapping rules is Javadoc where we aim to wrap around 80 characters for maximum readability in all kinds of contexts, e.g. reading on Github, on your phone, etc.

@nkjackzhang
Copy link
Contributor Author

nkjackzhang commented Jul 1, 2016

Sorry, I use github web page to make commit.You are welcome to search the remains by yourself.And you can just close this PR.

@snicoll snicoll closed this in 037746d Jul 1, 2016
@snicoll snicoll self-assigned this Jul 1, 2016
jhoeller pushed a commit that referenced this pull request Jul 1, 2016
Closes gh-1097
(cherry picked from commit 037746d)
@nkjackzhang nkjackzhang deleted the patch-4 branch July 6, 2016 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants