HeaderResultMatchers should not import org.junit.Assert

[philwebb]

It looks like HeaderResultMatchers is accidentally importing org.junit.Assert.assertNotNull rather than our own org.springframework.test.util.AssertionErrors.

I wonder if we can put a checkstyle rule to prevent junit imports in src/main

[rstoyanchev]

Seems reasonable outside of spring-test.

[sbrannen]

I agree.

I'll fix the import and implement assertNotNull() in our own AssertionErrors.

As for the checkstyle rule only applied to src/main, @philwebb do you want to do that, or shall I pick that up as well?

[sbrannen]

Reopening for the potential inclusion of a Checkstyle rule to prevent this in the future.