MockHttpServletRequest with Host: set builds wrong getRequestURL() [SPR-16138]

[spring-projects-issues]

Steven Schlansker opened SPR-16138 and commented

MockHttpServletRequest has a serverName field, but the getter does additional logic around parsing the Host: header. This leads to inconsistency when getRequestURL reflects a different serverName than getServerName does.

#1579

---

Affects: 4.3.12

Issue Links:

• MockHttpServletRequest should honor "Host" header in getServerName() and getServerPort() [SPR-12088] #16704 MockHttpServletRequest should honor "Host" header in getServerName() and getServerPort()
• MockHttpServletResponse.getDateHeader fails with NPE for non-existing header [SPR-16160] #20708 MockHttpServletResponse.getDateHeader fails with NPE for non-existing header

Referenced from: commits 9ca4de1, 0edf4d6

Backported to: 4.3.13

[spring-projects-issues]

Juergen Hoeller commented

Good point... I guess the same applies to getServerPort() as well?

[spring-projects-issues]

Juergen Hoeller commented

I've addressed this as part of a larger revision along with #20708, also covering the server port case.