SettableListenableFuture may be successfully set with failureCallback executed and success callback ignored [SPR-15216]

[spring-projects-issues]

Ivan Sopov opened SPR-15216 and commented

Version that I tested is 4.3.7.BUILD-SNAPSHOT with the fix for #19766

I've checked fix for #19766 and it works. But I have wrote another test:

https://github.com/isopov/isopov-jcstress/blob/master/src/main/java/com/sopovs/moradanen/jcstress/spring/SettableListenableFuture2Test.java

It reveals that it is possible to successfully set value for this future, but success callback will not be executed and failure callback instead will be called. As in previous case it is the case of concurrently setting and cancelling future under race.

---

Affects: 4.3.6

Issue Links:

• SettableListenableFuture may be both set and canceled successfully [SPR-15202] #19766 SettableListenableFuture may be both set and canceled successfully
• SettableListenableFuture set has a race on Java6 (and old versions of Java7) [SPR-16183] #20731 SettableListenableFuture set has a race on Java6 (and old versions of Java7)
• SettableListenableFuture setException is inconsistent with callbacks under race [SPR-15409] #19972 SettableListenableFuture setException is inconsistent with callbacks under race

[spring-projects-issues]

Juergen Hoeller commented

Good catch! I've revised our SettableListenableFuture implementation once more, now centralizing all state into the inner FutureTask subclass (through overriding FutureTask.set and FutureTask.setException and bypassing FutureTask.run completely).

I'll ping you once this is available in a new 4.3.7 snapshot.

[spring-projects-issues]

Juergen Hoeller commented

A new 4.3.7.BUILD-SNAPSHOT containing this latest variant of SettableListenableFuture is available now. Please give it a try...

[spring-projects-issues]

Ivan Sopov commented

Thanks, my jcstress-based tests pass.