Useless exception message when annotations can't be parsed [SPR-12507]

[spring-projects-issues]

Aaron Digulla opened SPR-12507 and commented

When a class is missing while parsing annotations in StandardAnnotationMetadata.isAnnotated, you get this exception:

java.lang.ArrayStoreException: sun.reflect.annotation.TypeNotPresentExceptionProxy
	at sun.reflect.annotation.AnnotationParser.parseClassArray(AnnotationParser.java:653)
	at sun.reflect.annotation.AnnotationParser.parseArray(AnnotationParser.java:460)
	at sun.reflect.annotation.AnnotationParser.parseMemberValue(AnnotationParser.java:286)
	at sun.reflect.annotation.AnnotationParser.parseAnnotation(AnnotationParser.java:222)
	at sun.reflect.annotation.AnnotationParser.parseAnnotations2(AnnotationParser.java:69)
	at sun.reflect.annotation.AnnotationParser.parseAnnotations(AnnotationParser.java:52)
	at java.lang.Class.initAnnotationsIfNecessary(Class.java:3079)
	at java.lang.Class.getAnnotations(Class.java:3059)
	at org.springframework.core.type.StandardAnnotationMetadata.isAnnotated(StandardAnnotationMetadata.java:123)

The error means that Java couldn't find a class inside of annotation which has a Class value.

Can you please wrap all exceptions thrown by Class.getAnnotations() with the name of the class which you tried to parse? That would help to narrow down the problem.

---

Affects: 3.2.10

Issue Links:

• java.lang.ArrayStoreException: sun.reflect.annotation.TypeNotPresentExceptionProxy exception when annotation config not found needs to specify what class is not found [SPR-10441] #15074 java.lang.ArrayStoreException: sun.reflect.annotation.TypeNotPresentExceptionProxy exception when annotation config not found needs to specify what class is not found ("duplicates")
• AnnotationUtils.findAnnotation fails with poor diagnostics if it encounters an Annotation that references an unloadable class [SPR-11874] #16493 AnnotationUtils.findAnnotation fails with poor diagnostics if it encounters an Annotation that references an unloadable class
• Improve diagnostics when AnnotationAttributesReadingVisitor triggers an ArrayStoreException from Class.getAnnotations() [SPR-12387] #16995 Improve diagnostics when AnnotationAttributesReadingVisitor triggers an ArrayStoreException from Class.getAnnotations()

[spring-projects-issues]

Aaron Digulla commented

As a workaround, copy the source for StandardAnnotationMetadata into your project and replace public boolean isAnnotated(String annotationType) with this code:

public boolean isAnnotated(String annotationType) {
    Class introspectedClass = getIntrospectedClass();
    try {
        Annotation[] anns = introspectedClass.getAnnotations();
        for (Annotation ann : anns) {
            if (ann.annotationType().getName().equals(annotationType)) {
                return true;
            }
            for (Annotation metaAnn : ann.annotationType().getAnnotations()) {
                if (metaAnn.annotationType().getName().equals(annotationType)) {
                    return true;
                }
            }
        }
    } catch( RuntimeException e ) {
        throw new RuntimeException( "Error parsing annotations of " + introspectedClass, e );
    }
    return false;
}

[spring-projects-issues]

Juergen Hoeller commented

Note that this has been fixed in the 4.0.x line and therefore also in 4.1.x already, as of 4.0.3 back in March. In more recent releases, there has been further fine-tuning in that respect since quite a few other places in the framework codebase can run into that same unpleasant JVM exception.

It's unlikely that we'll backport all of these changes. I strongly recommend an upgrade to 4.0.6 at least... or right away to 4.1.3, scheduled for next week.

Juergen