Minor code tweaks in Apache HttpClient based HTTP request factories [SPR-10869]

[spring-projects-issues]

Oleg Kalnichevski opened SPR-10869 and commented

Post #13446 minor code tweaks in HTTP request factories based on Apache HttpClient and Apache HttpAsyncClient. Most of the changes are related to the use of new HttpClient 4.3 configuration APIs.

---

Reference URL: #350

[spring-projects-issues]

Oleg Kalnichevski commented

Pull request: #347

[spring-projects-issues]

Oleg Kalnichevski commented

Pull request: #350

incorporates feedback on #347 and some minor performance / memory footprint optimizations.

[spring-projects-issues]

Jongwook Choi commented

Hello,

this change seems to introduce a constraint on version: Apache HttpClient >= 4.3.x: using Apache HttpClient 4.2 on classpath, we get a NoClassDefFoundError.
Does spring 4.0 mean to require HttpClient 4.3 or higher? (is that dependency optional or required)

Should I create a new issue w.r.t this one?
Thanks!

[spring-projects-issues]

Rossen Stoyanchev commented

Yes HttpClient 4.3 is a required minimum version with Spring Framework 4.0.