Deadlock on the beanDefinitionMap and singletonObjects [SPR-9199]

[spring-projects-issues]

LiangFei opened SPR-9199 and commented

1. init BeanX (a RPC bean)
2. RPC -> BeanX -> getBean() // get bean thread
3. init BeanY // init context thread

The "get bean thread" and the "init context thread" deadlock.

1. get bean thread:
   (a) DefaultSingletonBeanRegistry.getSingleton(): synchronized(singletonObjects)
   (b) -> getObject() -> DefaultListableBeanFactory.getBeanNames(): synchronized(beanDefinitionMap)

2. init context thread:
   (a) DefaultListableBeanFactory.preInstantiateSingletons(): synchronized(beanDefinitionMap)
   (b) -> getBean() -> DefaultSingletonBeanRegistry.getSingleton(): synchronized(singletonObjects)

---

Affects: 2.5.6

Attachments:

• lock-get-bean.jpg (107.23 kB)
• lock-init-context.jpg (38.31 kB)

Issue Links:

• Performance bottleneck and potential thread deadlock in DefaultSingletonBeanRegistry [SPR-8471] #13117 Performance bottleneck and potential thread deadlock in DefaultSingletonBeanRegistry ("duplicates")

[spring-projects-issues]

LiangFei commented

Always first lock the "beanDefinitionMap", may be able to solve the problem.