Add option to check for matching number of arguments for a given PreparedStatement in ArgPreparedStatementSetter and enhance JdbcTemplate to optionally use it [SPR-5678]

[spring-projects-issues]

Joris Kuipers opened SPR-5678 and commented

Currently, ArgPreparedStatementSetter.setValues simply applies the values in the args array it was created with to the given PreparedStatement. That means that if there are less arguments than placeholders, the remaining placeholders will be null. This is valid behavior in some cases, but in many cases I'd argue that this indicates a programmer error (forgetting a parameter).
It might be nice to add an option to setValues to optionally check for a matching count of arguments and placeholders. The latter can be obtained from the PreparedStatement's ParameterMetaData. The JdbcTemplate can then be updated to enable this feature so this programming error would be caught early, instead of indirectly by running the statement with accidental null values.
By disabling the option by default everything remains backwards compatible.

---

Affects: 2.5.6

[spring-projects-issues]

Thomas Risberg commented

This is only an issue for HSQL - other databases throw some kind of SQLException:

Oracle: java.sql.SQLException: Missing IN or OUT parameter at index:: 3
MySQL: java.sql.SQLException: No value specified for parameter 3
DB2: com.ibm.db2.jcc.c.SqlException: [ibm][db2][jcc][10143][10845] Invalid parameter 3: Parameter is not set nor registered.
MSSQL: com.microsoft.sqlserver.jdbc.SQLServerException: The value is not set for the parameter number 3.
Derby: java.sql.SQLException: At least one parameter to the current statement is uninitialized.
H2: org.h2.jdbc.JdbcSQLException: Parameter #3 is not set [90012-71]

So the conclucions is that this is not worth fixing since it would add additional complexity.