Skip to content

[docs] Correct resource name in query method section #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jgreub
Copy link
Contributor

@jgreub jgreub commented Jan 13, 2020

I believe this is supposed to say "query method resource" instead of "search resource" since it is in the query method resource section. I believe it said "search" because it was copied from the search resource section above.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

I believe this is supposed to say "query method resource" instead of "search resource" since it is in the query method resource section.  I believe it said "search" because it was copied from the search resource section above.
@pivotal-issuemaster
Copy link

@jgreub Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@jgreub Thank you for signing the Contributor License Agreement!

@jgreub
Copy link
Contributor Author

jgreub commented Jan 13, 2020

I was also going to submit another PR about the navigation on the reference docs. When you scroll through the sub-sections in a top-level section, a lot of the time the navigation table of contents on the left sidebar does NOT highlight the right section. It instead highlights a previous section. I believe it is related to missing section "links" (such as [[tools.hal-browser]]), but I am not an asciidocs expert.

Also, not sure why the CI build failed.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2021
@gregturn gregturn changed the base branch from master to main April 16, 2021 17:55
odrotbohm pushed a commit that referenced this pull request Jul 16, 2021
@odrotbohm odrotbohm closed this in 7bb34d7 Jul 16, 2021
odrotbohm pushed a commit that referenced this pull request Jul 16, 2021
@odrotbohm odrotbohm added this to the 3.4.11 (2020.0.11) milestone Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants