DATAJDBC-258 - Enable Integration tests for MS-SQL-Server. #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@THD-Thomas-Lang Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@THD-Thomas-Lang Thank you for signing the Contributor License Agreement! |
schauder
changed the title
schauder
pushed a commit
that referenced
this pull request
Nov 1, 2018
This adds MS-SQL-Server via Testcontainers to the set of databases available for integration testing. For this purpose it accepts the EULA of MS SQL Server. Failing tests are ignored to be fixed in separate issues. Original pull request: #98.
schauder
added a commit
that referenced
this pull request
Nov 1, 2018
Simplified id value retrieval. Simplified ignoring tests for a specific database. Fixed property name in pom.xml. Original pull request: #98.
schauder
added a commit
that referenced
this pull request
Nov 1, 2018
Added mssql to the readme as available database for tests. Original pull request: #98.
|
That's squashed, polished and merged into master. Thank you very much @THD-Thomas-Lang. |
mp911de
added a commit
that referenced
this pull request
Feb 21, 2022
We now provide an abstract base class for ConnectionFactory routing. Routing keys are typically obtained from a subscriber context. AbstractRoutingConnectionFactory is backed by either a map of string identifiers or connection factories. When using string identifiers, these can map agains e.g. Spring bean names that can be resolved using BeanFactoryConnectionFactoryLookup.
class MyRoutingConnectionFactory extends AbstractRoutingConnectionFactory {
@OverRide
protected Mono<Object> determineCurrentLookupKey() {
return Mono.subscriberContext().filter(it -> it.hasKey(ROUTING_KEY)).map(it -> it.get(ROUTING_KEY));
}
}
@bean
public void routingConnectionFactory() {
MyRoutingConnectionFactory router = new MyRoutingConnectionFactory();
Map<String, ConnectionFactory> factories = new HashMap<>();
ConnectionFactory myDefault = …;
ConnectionFactory primary = …;
ConnectionFactory secondary = …;
factories.put("primary", primary);
factories.put("secondary", secondary);
router.setTargetConnectionFactories(factories);
router.setDefaultTargetConnectionFactory(myDefault);
return router;
}
Original pull request: #132.
mp911de
pushed a commit
that referenced
this pull request
Feb 21, 2022
Formatting. Changed generics to avoid unchecked casting. Avoided abbreviated variable name. Simplified handling of absent keys at ConnectionFactory lookup. Original pull request: #132.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue DATAJDBC-258.