DATAJDBC-166 - Allow registration of RowMappers based on result type. #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
force-pushed
the
issue/DATAJDBC-166
branch
from
7687e3e to
7ba4d16
Compare
RowMapper can be configured either via the @query(rowMapperClass = ….) or by registerign a RowMapperMap bean and register RowMapper per method return type. @bean RowMapperMap rowMappers() { return new ConfigurableRowMapperMap() // .register(Person.class, new PersonRowMapper()) // .register(Address.class, new AddressRowMapper()); } When determining the RowMapper to use for a method the following steps are followed based on the return type of the method: 1. If the type is a simple type no RowMapper is used. Instead the query is expected to return a single row with a single column and a conversion to the return type is applied to that value. 2. The entity classes in the RowMapperMap are iterated until one is found that is a superclass or interface of the return type in question. The RowMapper registered for that class is used. Iterating happens in the order of registration, so make sure to register more general types after specific ones. If applicable wrapper type like collections or Optional are unwrapped. So a return type of Optional<Person> will use the type Person in the steps above.
Formatting. Import order. Use of AssertJ.
schauder
force-pushed
the
issue/DATAJDBC-166
branch
from
7ba4d16 to
49b99c2
Compare
|
Resolved via a2b7699 |
mp911de
added a commit
that referenced
this pull request
Feb 21, 2022
DatabaseClient now no longer exposes the exchange() method but rather provides map(…) and then(…) methods. Calling map(…) extracts values from tabular results by propagating the mapping function to Result.map(…). then() allows statement execution without returning the result propagating only completion and error signals. Original pull request: #33.
mp911de
pushed a commit
that referenced
this pull request
Feb 21, 2022
Formatting, JavaDoc, issue comments on `@Test` annotations. Removed some dead code. Original pull request: #33.
mp911de
added a commit
that referenced
this pull request
Feb 21, 2022
Remove unused code from AbstractDatabaseClientIntegrationTests. Use literal null instead of code null for consistency. Original pull request: #33.
mp911de
added a commit
that referenced
this pull request
Feb 21, 2022
Move retrieval methods from FetchSpec into RowsFetchSpec and UpdatedRowsFetchSpec. map(…) now returns RowsFetchSpec to not expose updated rows count as mapped results are consumed as objects. Original pull request: #33.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RowMapper can be configured either via the @query(rowMapperClass = ….) or by registerign a RowMapperMap bean and register RowMapper per method return type.
When determining the RowMapper to use for a method the following steps are followed based on the return type of the method:
If the type is a simple type no RowMapper is used. Instead the query is expected to return a single row with a single column and a conversion to the return type is applied to that value.
The entity classes in the RowMapperMap are iterated until one is found that is a superclass or interface of the return type in question. The RowMapper registered for that class is used. Iterating happens in the order of registration, so make sure to register more general types after specific ones.
If applicable wrapper type like collections or Optional are unwrapped. So a return type of Optional will use the type Person in the steps above.