DATAJDBC-161: Share an SqlSession into a same transaction #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
requested changes
Jan 8, 2018
There was a problem hiding this comment.
Thank you for taking a look and spending time on this. Very much appreciated.
I marked a couple of changes where I don't understand how they are related to DATAJDBC-161. Could you please clarify, or remove them from the commit?
Even just confirming if they are unrelated would be fine, I can take it from there.
| @@ -24,9 +24,12 @@ | |||
| @Alias("DummyEntity") | |||
| class DummyEntity { | |||
|
|
|||
| @Id final Long id; | |||
| @Id final long id; | |||
There was a problem hiding this comment.
This change seems unrelated to DATAJDBC-161, possibly related to DATAJDBC-160
| */ | ||
| @ContextConfiguration | ||
| @Transactional | ||
| public class MyBatisBatchHsqlIntegrationTests { |
There was a problem hiding this comment.
Again I don't understand the connection to the issue this tries to fix.
| @@ -12,11 +12,19 @@ | |||
| <insert id="insert" parameterType="MyBatisContext" useGeneratedKeys="true" keyProperty="instance.id" keyColumn="ID"> | |||
| INSERT INTO DummyEntity (id) VALUES (DEFAULT) | |||
| </insert> | |||
| <select id="findById" resultType="MyBatisContext" resultMap="dummyEntityMap"> | |||
| <select id="findById" resultMap="dummyEntityMap"> | |||
There was a problem hiding this comment.
Again possibly unrelated to the issue at hand.
|
Took the essential part, polished and merged it. Thanks. |
|
@schauder Thanks for fixes! |
mp911de
pushed a commit
that referenced
this pull request
Feb 21, 2022
Postgres integration tests now run either with a locally installed and started database or if no such database can be found an instance gets started in a Docker container via Testcontainers. We prefer a database based on TestContainers. Only if this can't be obtained do we try to access a local database for Postgres. This minimizes the risk of accessing a database during tests that is not intended for that purpose. If the system property `spring.data.r2dbc.test.preferLocalDatabase` is set to "true" the local database is preferred. Original pull request: #51.
mp911de
added a commit
that referenced
this pull request
Feb 21, 2022
Add author tags. Add static factory method to create an unavailable database object instance. Simplify database selection. Javadoc. Original pull request: #51.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the DATAJDBC-161.
Please review this.