Skip to content

DATAJDBC-349 - Use JdbcConverter on relation id property. #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DATAJDBC-349 - Use JdbcConverter on relation id property. #248

wants to merge 1 commit into from

Conversation

lseeker
Copy link
Contributor

@lseeker lseeker commented Sep 12, 2020

Resolves error when id property needs type convert.
When resolves relations, id property didn't use JdbcConverter. This PR address it.

@schauder
Copy link
Contributor

schauder commented Oct 2, 2020

At first glance, this looks pretty good already.

Could you add a set of unit tests that verifies the right conversion is happening? DefaultDataAccessStrategyUnitTests looks like the right place for that.

@schauder
Copy link
Contributor

schauder commented Oct 5, 2020

Don't worry #242 or the issue it fixes is a dupe and the PR has the unit test I was looking for. I'll merge both PRs.

schauder pushed a commit that referenced this pull request Oct 13, 2020
@lseeker @schauder
DATAJDBC-349 - Apply JdbcConverter on reference ids.
dc535e9 
Original pull request: #248.
schauder added a commit that referenced this pull request Oct 13, 2020
@schauder
DATAJDBC-349 - Polishing.
66e3ad9 
Original pull requests: #248, #242.
Fixes superfluous commata and unsupported data types.
Cleaning up database objects before (re)creating them.
schauder added a commit that referenced this pull request Oct 13, 2020
@schauder
DATAJDBC-349 - Polishing.
6a9aa51 
Original pull requests: #248, #242.
@schauder schauder mentioned this pull request Oct 13, 2020
Closed
@schauder
Copy link
Contributor

Thanks.
That's merged, polished and combined with #242.

There were some minor issues with the integration tests.
Please see https://github.com/spring-projects/spring-data-jdbc#running-integration-tests for how to run integration tests locally.

@schauder schauder closed this Oct 13, 2020
@lseeker lseeker deleted the issue/DATAJDBC-349 branch November 11, 2020 13:14
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lseeker lseeker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lseeker @schauder