DATAJDBC-257 - Adds DB2 support. … #213
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Db2Dialect added in order to support DB2. Added test configuration files. Adapted some tests to make them properly work with DB2 QueryAnnotationIntegrationTests converted into an Hsqldb only test since it is next to impossible to make it work across databases since it heavily depends on database and driver specifics. Removed license acceptance file from the repository in order to not accept a license in the name of someone forking the repository. For the CI build an appropriate file gets created on the fly.
mp911de
reviewed
May 5, 2020
spring-data-jdbc/pom.xml
Outdated
| @@ -185,6 +185,25 @@ | |||
| <version>${mssql.version}</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <!-- | |||
mp911de
reviewed
May 5, 2020
| import org.testcontainers.containers.Db2Container; | ||
|
|
||
| /** | ||
| * {@link DataSource} setup for HSQL. |
| @@ -0,0 +1,93 @@ | |||
| /* | |||
| * Copyright 2019-2020 the original author or authors. | |||
There was a problem hiding this comment.
Nit: Inception year of this file is 2020.
mp911de
reviewed
May 5, 2020
| @@ -0,0 +1,59 @@ | |||
| /* | |||
| * Copyright 2017-2020 the original author or authors. | |||
Removed superfluous commented code and imports. Fixed year in copyright blocks. Improved Javadoc comments.
|
@mp911de your turn again. |
mp911de
pushed a commit
that referenced
this pull request
May 6, 2020
Db2Dialect added in order to support DB2. Added test configuration files. Adapted some tests to make them properly work with DB2 QueryAnnotationIntegrationTests converted into an Hsqldb only test since it is next to impossible to make it work across databases since it heavily depends on database and driver specifics. Removed license acceptance file from the repository in order to not accept a license in the name of someone forking the repository. For the CI build an appropriate file gets created on the fly. Original pull request: #213.
mp911de
added a commit
that referenced
this pull request
May 6, 2020
Move container initialization from static initializer into createDataSource() to not trigger container start when loading the class. Add TestExecutionListener to ignore tests if the license for a container was not accepted. Add Awaitility to delay test execution until the database is ready so we avoid strange failures due to a delayed container startup. Fix generics, since tags, author tags. Reformat code. Original pull request: #213.
|
That's merged and polished now. |
mp911de
added a commit
that referenced
this pull request
May 6, 2020
Move container initialization from static initializer into createDataSource() to not trigger container start when loading the class. Add TestExecutionListener to ignore tests if the license for a container was not accepted. Add Awaitility to delay test execution until the database is ready so we avoid strange failures due to a delayed container startup. Fix generics, since tags, author tags. Reformat code. Original pull request: #213.
mp911de
added a commit
that referenced
this pull request
Feb 21, 2022
Consistently apply summing of updated rows. Tweak copyright years in license header to reflect file inception year. Original pull request: #213.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Db2Dialect added in order to support DB2.
Added test configuration files.
Adapted some tests to make them properly work with DB2
QueryAnnotationIntegrationTests converted into an Hsqldb only test since it is next to impossible to make it work across databases since it heavily depends on database and driver specifics.
Removed license acceptance file from the repository in order to not accept a license in the name of someone forking the repository.
For the CI build an appropriate file gets created on the fly.
Issue: DATAJDBC-257