GH-2064 BeforeConvertCallback should be applied after the RootAggrega… #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

mipo256 wants to merge 1 commit into spring-projects:main from mipo256:GH-2064

Contributor

mipo256 commented Jun 1, 2025

Closes #2064

Hey @mp911de, @schauder.

After giving it a couple of tries, I've come up with this solution. The idea is to separate the doInBatch and saveInBatch. The reason is that in doInBatch there is an implicit assumption, that the Function that accepts the entity to create an AggregateChange will just create an AggregateChange. But in case of saveAll, there were a conditional logic also applied in the Function (like what change to create, UPDATE or INSERT).

So, in case of any suggestions or question, feel free to reach out, thanks!


          spring-projectsGH-2064 BeforeConvertCallback should be applied after …

d157a18

…the RootAggregateChange creation

Signed-off-by: mipo256 <mikhailpolivakha@gmail.com>

spring-projects-issues added the status: waiting-for-triage label

mp911de assigned schauder

mp911de added type: bug and removed status: waiting-for-triage labels

Member

mp911de commented Jun 2, 2025

Thanks a lot for having a look and picking up on maintenance, this is really helpful.

schauder pushed a commit that referenced this pull request


          Applies proper event handling before saving in batch.

21b74e2

Signed-off-by: mipo256 <mikhailpolivakha@gmail.com>

Commit message edited by Jens Schauder.

Original pull request #2065
Closes #2064

schauder added a commit that referenced this pull request


          Fixes integration tests.

aa843bf

Adding sizes to VARCHAR fields.

Original pull request #2065
See #2064

schauder added a commit that referenced this pull request


          Switch to VARCHAR2 for Oracle tests.

712b180

VARCHAR should not be used with Oracle.

Original pull request #2065
See #2064

schauder added a commit that referenced this pull request


          Polishing.

e82befd

Formatting.
Simplification of code.

Original pull request #2065
See #2064

Contributor

schauder commented Jun 11, 2025

Thanks for this.

I had to apply some changes:

The integration tests for Sql Server and Oracle failed to errors in the SQL scripts. You can run all integration tests by running ./mvnw clean verify -Pall-dbs.
Formatting was a little off. Wildcard imports weren't applied as they should. You might want to check your setup.

This is merged.
Thanks again.

schauder pushed a commit that referenced this pull request


          Applies proper event handling before saving in batch.

651a4f5

Signed-off-by: mipo256 <mikhailpolivakha@gmail.com>

Commit message edited by Jens Schauder.

Original pull request #2065
Closes #2064

schauder added a commit that referenced this pull request


          Fixes integration tests.

c00158a

Adding sizes to VARCHAR fields.

Original pull request #2065
See #2064

schauder added a commit that referenced this pull request


          Switch to VARCHAR2 for Oracle tests.

e7a7bec

VARCHAR should not be used with Oracle.

Original pull request #2065
See #2064

schauder added a commit that referenced this pull request


          Polishing.

1511e15

Formatting.
Simplification of code.

Original pull request #2065
See #2064

schauder pushed a commit that referenced this pull request


          Applies proper event handling before saving in batch.

5b3fa3d

Signed-off-by: mipo256 <mikhailpolivakha@gmail.com>

Commit message edited by Jens Schauder.

Original pull request #2065
Closes #2064

schauder added a commit that referenced this pull request


          Fixes integration tests.

1a98151

Adding sizes to VARCHAR fields.

Original pull request #2065
See #2064

schauder added a commit that referenced this pull request


          Switch to VARCHAR2 for Oracle tests.

e2c0851

VARCHAR should not be used with Oracle.

Original pull request #2065
See #2064

schauder added a commit that referenced this pull request


          Polishing.

376dce4

Formatting.
Simplification of code.

Original pull request #2065
See #2064

schauder added this to the 3.4.7 (2024.1.7) milestone

schauder closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels