Skip to content

DATAJDBC-370 - Fixed handling of entities with no withers. #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

schauder
Copy link
Contributor

@schauder schauder commented May 8, 2019

We tried to set all the properties, even when they were already set via constructor.
Fixed it by unifying the three instances where we created and populated instances.

Issue: https://jira.spring.io/browse/DATAJDBC-370

schauder and others added 6 commits May 8, 2019 07:47
Adding a missing issue reference to a test.
We tried to set all the properties, even when they were already set via constructor.
Fixed it by unifying the three instances where we created and populated instances.
Reade wither method and add explicit test for immutable value.
We now allow read and write of Objects annotated with Embedded that are actually null.
When writing all contained fields will be nulled.
Reading back the entity considers an embedded object to be null itself if all contained properties are null within the backing result.

Relates to DATAJDBC-364
Refactored code to better use existing code.
christophstrobl pushed a commit that referenced this pull request May 13, 2019
Adding a missing issue reference to a test.

Original Pull Request: #151
christophstrobl pushed a commit that referenced this pull request May 13, 2019
We tried to set all the properties, even when they were already set via constructor.
Fixed it by unifying the three instances where we created and populated instances.

Original Pull Request: #151
christophstrobl added a commit that referenced this pull request May 13, 2019
Re add wither method and add explicit test for immutable value.

Original Pull Request: #151
christophstrobl added a commit that referenced this pull request May 13, 2019
We now allow read and write of Objects annotated with Embedded that are actually null.
When writing all contained fields will be nulled.
Reading back the entity considers an embedded object to be null itself if all contained properties are null within the backing result.

Relates to DATAJDBC-364

Original Pull Request: #151
christophstrobl pushed a commit that referenced this pull request May 13, 2019
Refactored code to better use existing code.

Original Pull Request: #151
@christophstrobl christophstrobl deleted the issue/DATAJDBC-370 branch May 13, 2019 07:56
mp911de pushed a commit that referenced this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants