DATAJDBC-335 - Add DSL and renderer for Insert, Update, and Delete. #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
requested changes
Mar 4, 2019
| @Override | ||
| public String toString() { | ||
|
|
||
| StringBuilder builder = new StringBuilder(32); |
There was a problem hiding this comment.
Assuming there is a good reason for the chosen initial capacity we should spend a comment to explain it.
There was a problem hiding this comment.
Probably there's no need for premature optimization. I'll check the other places as well.
| * @return {@code this} builder. | ||
| * @see Assignment | ||
| */ | ||
| UpdateAssignAnd and(Assignment assignment); |
There was a problem hiding this comment.
I find a series of set calls more intuitive than and.
How about offering set as an alias to and?
We even could go for a vararg:
Update update = StatementBuilder.update(table)
.set(
foo.set(SQL.bindMarker()),
bar.set(SQL.bindMarker())
).build();
There was a problem hiding this comment.
and(…) and or(…) syntax aligns with the where and join syntax. We can accept varargs here, probably, also a Collection<? extends Assignment>.
There was a problem hiding this comment.
The difference to joins and where syntax I see is that in SQL there is no AND between assignments.
mp911de
commented
Mar 5, 2019
| assertThatThrownBy(() -> { | ||
| Select.builder().select(bah).from(foo).where(Conditions.in(bar, subselect)).build(); | ||
| }).isInstanceOf(IllegalStateException.class) | ||
| .hasMessageContaining("Required table [bah] by a SELECT column not imported by FROM [foo] or JOIN []"); |
There was a problem hiding this comment.
This should be rather: Required table [floo]
mp911de
force-pushed
the
issue/DATAJDBC-335
branch
from
119a83f to
e7cf62d
Compare
We now provide Statement builders for Insert, Update, and Delete statements.
Table myTable = SQL.table("mytable");
Insert insert = StatementBuilder.insert().into(myTable).values(SQL.bindMarker()).build();
Update update = StatementBuilder.update(table).set(myTable.column("foo").set(SQL.bindMarker())).build();
Delete delete = StatementBuilder.delete().from(table).where(myTable.column("foo").isEqualTo(SQL.literal("bar"))).build();
Formatting and one additional test.
mp911de
force-pushed
the
issue/DATAJDBC-335
branch
from
e7cf62d to
33472b7
Compare
schauder
pushed a commit
that referenced
this pull request
Mar 5, 2019
We now provide Statement builders for Insert, Update, and Delete statements.
Table myTable = SQL.table("mytable");
Insert insert = StatementBuilder.insert().into(myTable).values(SQL.bindMarker()).build();
Update update = StatementBuilder.update(table).set(myTable.column("foo").set(SQL.bindMarker())).build();
Delete delete = StatementBuilder.delete().from(table).where(myTable.column("foo").isEqualTo(SQL.literal("bar"))).build();
Original pull request: #121.
schauder
added a commit
that referenced
this pull request
Mar 5, 2019
Formatting and one additional test. Original pull request: #121.
|
That is merged. |
THD-Thomas-Lang
pushed a commit
to THD-Thomas-Lang/spring-data-jdbc
that referenced
this pull request
Apr 12, 2019
We now provide Statement builders for Insert, Update, and Delete statements.
Table myTable = SQL.table("mytable");
Insert insert = StatementBuilder.insert().into(myTable).values(SQL.bindMarker()).build();
Update update = StatementBuilder.update(table).set(myTable.column("foo").set(SQL.bindMarker())).build();
Delete delete = StatementBuilder.delete().from(table).where(myTable.column("foo").isEqualTo(SQL.literal("bar"))).build();
Original pull request: spring-projects#121.
THD-Thomas-Lang
pushed a commit
to THD-Thomas-Lang/spring-data-jdbc
that referenced
this pull request
Apr 12, 2019
Formatting and one additional test. Original pull request: spring-projects#121.
THD-Thomas-Lang
pushed a commit
to THD-Thomas-Lang/spring-data-jdbc
that referenced
this pull request
Apr 12, 2019
Original pull request: spring-projects#121.
mp911de
pushed a commit
that referenced
this pull request
Feb 21, 2022
mp911de
pushed a commit
that referenced
this pull request
Feb 21, 2022
mp911de
pushed a commit
that referenced
this pull request
Feb 21, 2022
mp911de
pushed a commit
that referenced
this pull request
Feb 21, 2022
mp911de
added a commit
that referenced
this pull request
Feb 21, 2022
Reuse inherited configuration from parent pom.
mp911de
pushed a commit
that referenced
this pull request
Feb 21, 2022
mp911de
pushed a commit
that referenced
this pull request
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support the building and rendering of
Insert,Update, andDeletestatements.We also support literal expressions for character and numeric constants.
Related ticket: DATAJDBC-335.