Skip to content

Fix docs on lifecycle events callbacks #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ctailor2
Copy link
Contributor

The current documentation on BeforeConvert and BeforeSave lifecycle events/callbacks is either incorrect or misleading. These documentation changes aim to clarify how they work along with how they are intended to be used.

@ctailor2 ctailor2 added the type: documentation A documentation update label Mar 18, 2022
@ctailor2 ctailor2 requested a review from schauder March 18, 2022 16:52
schauder pushed a commit that referenced this pull request Mar 22, 2022
schauder pushed a commit that referenced this pull request Mar 22, 2022
schauder pushed a commit that referenced this pull request Mar 22, 2022
schauder pushed a commit that referenced this pull request Mar 22, 2022
@schauder
Copy link
Contributor

Thanks, that's merged and ported to all relevant branches.

@schauder schauder closed this Mar 22, 2022
@schauder schauder deleted the issue/fix-docs-on-lifecycle-events-callbacks branch March 22, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants