Skip to content

DATAJDBC-331 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

DATAJDBC-331 #117

wants to merge 4 commits into from

Conversation

schlagi123
Copy link
Contributor

I hope this fix the issue.

mp911de
mp911de requested changes Feb 11, 2019
View reviewed changes
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you. I left a few comments, mostly high-level and polishing stuff. Care to have a look?

@schlagi123
Copy link
Contributor Author

I hope, I have fixed the polishing issues.

@mp911de
Copy link
Member

mp911de commented Feb 13, 2019

Thanks a lot. We'll take this pull request from here.

mp911de pushed a commit that referenced this pull request Feb 13, 2019
@schlagi123 @mp911de
DATAJDBC-331 Introduce @MappedCollection annotation.
6fcff3e 
We now provide a @MappedCollection annotation as replacement for @column's keyColumn attribute.

class Person {
  @MappedCollection(idColumn = "the_id", keyColumn = "the_key")
  private List<Integer> mappedList;
}

Original pull request: #117.
mp911de added a commit that referenced this pull request Feb 13, 2019
@mp911de
DATAJDBC-331 - Polishing.
61a54ca 
Simplify column name discovery using Optionals utility methods. Add test to verify Column annotation precedence.

Javadoc, formatting.

Original pull request: #117.
@mp911de
Copy link
Member

mp911de commented Feb 13, 2019

That's merged and polished now.

@mp911de mp911de closed this Feb 13, 2019
@schlagi123 schlagi123 deleted the issue/DATAJDBC-331 branch February 18, 2019 16:15
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 31, 2020
Closed
mp911de added a commit that referenced this pull request Feb 21, 2022
@mp911de
#117 - Upgrade to jasync-sql 0.9.51.
4a46692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schlagi123 @mp911de