DATAREDIS-293 - JedisConnection, allow bulk addition with same score. #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophstrobl
added a commit
that referenced
this pull request
Apr 7, 2014
Added version check for jedis library as the operation had been introduced in 2.4. Original Pull Request: #63
|
I think the code had already been changed in an incompatible way before my pull request. If you look at the method signature for zadd in 2.2 vs 2.4 the map key and value were swapped: JedisConnection had already been changed to use the new Map layout without doing a version check so I wasn't sure if 2.2 was still supported. So even with this check, adding multiple elements with different scores is actually broke because the score and element are inverted in the map. If the goal is to keep supporting Jedis 2.2 then we may need two versions of zAddArgs method. |
Prepare issue branch.
Added version check for jedis library as the operation had been introduced in 2.4. Original Pull Request: #63
thomasdarimont
pushed a commit
that referenced
this pull request
Apr 11, 2014
Added version check for jedis library as the operation had been introduced in 2.4. Original Pull Request: #63
|
Merged into master 6d7c5ce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged and polished pull request #62.
Added
jedisversion check to retain behavior for older versions.