Skip to content

DATAREDIS-1042 - Add support for MKSTREAM parameter when creating a Consumer Group #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tgrall
Copy link
Contributor

@tgrall tgrall commented May 3, 2020

It is my first contribution to Spring Data/Spring Data Redis, so I am not used yet to this project.

I have not done anything serious with Kotlin, I will need some help from the community to add more tests.


  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

tgrall added 2 commits May 3, 2020 17:32
Allow Group to be created without an existing stream, support of MKSTREAMS - issue spring-projects#1042
@pivotal-issuemaster
Copy link

@tgrall Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@tgrall Thank you for signing the Contributor License Agreement!

@mp911de mp911de changed the title Issue 1042 -- Add support for MKSTREAM parameter when creating a Consumer Group DATAREDIS-1042 - Add support for MKSTREAM parameter when creating a Consumer Group May 6, 2020
mp911de pushed a commit that referenced this pull request May 7, 2020
mp911de added a commit that referenced this pull request May 7, 2020
Set MKSTREAM by default when calling createGroup on the operations API as that should be the default behavior in the first place. Reformat code. Add since tags.

Original pull request: #527.
@mp911de
Copy link
Member

mp911de commented May 7, 2020

Thank you for your contribution. That's merged and polished now. We decided to create groups always with MKSTREAM enabled when using the operations API which is the typical abstraction being used. On the connection level, we preserved the option to set MKSTREAM.

@mp911de mp911de closed this May 7, 2020
mp911de added a commit that referenced this pull request May 7, 2020
Set MKSTREAM by default when calling createGroup on the operations API as that should be the default behavior in the first place. Reformat code. Add since tags.

Original pull request: #527.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants